Added 'LuaRocks' Dependency #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In an ideal world, rather than adding every language package manager as a dependency for Compile, Compile could derive that a Dependency of the kind But since Awesome and by extension Lua are already in the default base system, just adding LuaRocks as a dependency here wouldn't be too problematic. |
Without the LuaRocks dependency, Runner doesn't include the LuaRocks alien tree. This causes dependencies like LuaRocks:MODULE_NAME to not be accessable during the Recipe build step.
Assuming all goes accordingly, it doesnt look too difficult to implement in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runnerdoesn't include theLuaRocksalien tree ifLuaRocksisn't listed as a dependency. This means that if a dependency likeLuaRocks:MODULE_NAMEneeds to be accessible at build time, the build may fail.This can be seen directly when trying to compile
Awesome 4.3, which requiresLuaRocks:lgi. As encountered in Recipes issue#128.